New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gecko Bug 1725850] part 1: Port editor/libeditor/crashtests/336104.html to WPT #30545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `setTimeout` for emulating original test as far as possible, but unfortunately, we need to change `data` URI of the `<iframe>` to `srcdoc` due to cross-origin error. Differential Revision: https://phabricator.services.mozilla.com/D124846 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: 232802020e08f98cf271608c3a2837e74425ecd2 gecko-reviewers: saschanaz
The test used CRLF. Therefore, you may see all lines are changed. Differential Revision: https://phabricator.services.mozilla.com/D124847 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: 3da11343fbf26fd5385756f0bbef4bb7c1de9279 gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124848 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: d97f699612ebc25b2af12b1bab14d62a464307b6 gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124849 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: f744eb44124282bf06e38e41c66fbd7a6fa8d051 gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124850 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: b7e917f0c9cc72655a7107240b332692867f7c75 gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124851 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: 105b4e292d99d921766525c9139bd311be78beb0 gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124852 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: dcd667a9d8e6f773d30862090afc23189f36615b gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124853 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: 0b7cd5022143c75a88305c7b7277327d3866296b gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124854 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: 1cbe007d5c3359eac0a6db839490e0cf826bf14d gecko-reviewers: saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D124855 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850 gecko-commit: 044710dfd5d144f6f334cf4692108940aba3a215 gecko-reviewers: saschanaz
wpt-pr-bot
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
setTimeout
for emulating original test as far as possible, butunfortunately, we need to change
data
URI of the<iframe>
tosrcdoc
due to cross-origin error.
Differential Revision: https://phabricator.services.mozilla.com/D124846
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1725850
gecko-commit: 232802020e08f98cf271608c3a2837e74425ecd2
gecko-reviewers: saschanaz