[WPT] Check base URLs in worker-interception-redirect.https.html #30699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 13, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3146235
branch
from
a8c423e
to
84043a7
Compare
This CL - Changes the response URL of a worker top-level script to `.../subdir/...` when intercepted by a service worker, to make worker's base URL directory different depending on whether the response URL or the current request URL is used. - Makes worker-interception-redirect-webworker.js/py to `fetch()`/`importScripts()` relative to its settings object's base URL, not `/service-workers/service-worker/resources/`, and checks the URLs intercepted by serviceworkers. This checks the settings object's base URL of the workers, and thus exposes that Chromium uses current request URLs instead of response URLs as base URL, which will be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/3145772. Bug: 861564 Change-Id: I32dbb4aae55aebd12c75b26bd4a503ce366b57a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3146235 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#920944}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3146235
branch
from
84043a7
to
889b69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL
.../subdir/...when intercepted by a service worker,to make worker's base URL directory different depending on
whether the response URL or the current request URL is used.
to
fetch()/importScripts()relative to itssettings object's base URL, not
/service-workers/service-worker/resources/, and checksthe URLs intercepted by serviceworkers.
This checks the settings object's base URL of the workers,
and thus exposes that Chromium uses current request URLs
instead of response URLs as base URL, which will be fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/3145772.
Bug: 861564
Change-Id: I32dbb4aae55aebd12c75b26bd4a503ce366b57a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3146235
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920944}