[wpt] Add tests for two grid issues. #30703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 13, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3158852
branch
from
4857bd3
to
b9cb608
Compare
Bug: 1111799, 1127715 Change-Id: I9de52b03ff6fe087bde18072c9f29dc437d43b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158852 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/main@{#920986}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3158852
branch
from
b9cb608
to
708151b
Compare
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 16, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 16, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 16, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 16, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 20, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic. This change
ensures that `next(" ")` is called until the entire string is processed.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 20, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic. This change
ensures that `next(" ")` is called until the entire string is processed.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 28, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Nov 28, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes web-platform-tests#30703.
servo-wpt-sync
pushed a commit
that referenced
this pull request
Nov 30, 2023
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.
Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.
Fixes #30703.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: 1111799, 1127715
Change-Id: I9de52b03ff6fe087bde18072c9f29dc437d43b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158852
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#920986}