Fix svg-rotate-3args-invalid-00{1,3,4,5}.html. #30860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertions in tests 1, 3, 4, and 5, that assert that *part* of the syntax of these transform functions will be ignored and part will still be honored, is not supported by the current specification at https://drafts.csswg.org/css-transforms-1/#svg-syntax (though it was likely in older versions). (I mentioned this briefly in web-platform-tests#30852.) Thus, this changes those tests to match test 2 and assume that the entire invalid value will be ignored. This causes these tests to change from failing to passing in all of Chromium, Gecko, and WebKit.
smfr
approved these changes
Sep 18, 2021
wojtek-rybak
pushed a commit
to RTBHOUSE/chromium
that referenced
this pull request
Sep 23, 2021
This removes Failure expectations for css-transforms tests that were fixed in the WPT repository in the following PRs: web-platform-tests/wpt#30177 web-platform-tests/wpt#30847 web-platform-tests/wpt#30852 web-platform-tests/wpt#30860 web-platform-tests/wpt#30861 web-platform-tests/wpt#30867 Bug: 1175179 Change-Id: Ief5ba2557a86dce584751293b72da9a471343b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175540 Auto-Submit: David Baron <dbaron@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#924020}
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
) The assertions in tests 1, 3, 4, and 5, that assert that *part* of the syntax of these transform functions will be ignored and part will still be honored, is not supported by the current specification at https://drafts.csswg.org/css-transforms-1/#svg-syntax (though it was likely in older versions). (I mentioned this briefly in web-platform-tests#30852.) Thus, this changes those tests to match test 2 and assume that the entire invalid value will be ignored. This causes these tests to change from failing to passing in all of Chromium, Gecko, and WebKit.
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This removes Failure expectations for css-transforms tests that were fixed in the WPT repository in the following PRs: web-platform-tests/wpt#30177 web-platform-tests/wpt#30847 web-platform-tests/wpt#30852 web-platform-tests/wpt#30860 web-platform-tests/wpt#30861 web-platform-tests/wpt#30867 Bug: 1175179 Change-Id: Ief5ba2557a86dce584751293b72da9a471343b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3175540 Auto-Submit: David Baron <dbaron@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#924020} NOKEYCHECK=True GitOrigin-RevId: a92e9a55e83af258c330978056b675e16dcad1a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertions in tests 1, 3, 4, and 5, that assert that part of the
syntax of these transform functions will be ignored and part will still
be honored, is not supported by the current specification at
https://drafts.csswg.org/css-transforms-1/#svg-syntax (though it was
likely in older versions). (I mentioned this briefly in #30852.)
Thus, this changes those tests to match test 2 and assume that the
entire invalid value will be ignored.
This causes these tests to change from failing to passing in all of
Chromium, Gecko, and WebKit.