Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some css highlight test cases #30905

Merged
merged 1 commit into from Sep 21, 2021
Merged

Rename some css highlight test cases #30905

merged 1 commit into from Sep 21, 2021

Conversation

WeizhongX
Copy link
Contributor

We now have tests with the same file name in chromium and wpt upstream,
which cause a merge conflict when exporting and importing the changes.
Rename the file names at upstream to resolve such conflict.

We now have tests with the same file name in chromium and wpt upstream,
which cause a merge conflict when exporting and importing the changes.
Rename the file names at upstream to resolve such conflict.
@KyleJu
Copy link
Contributor

KyleJu commented Sep 21, 2021

@delan FYI!

@WeizhongX WeizhongX merged commit 4f50940 into master Sep 21, 2021
@WeizhongX WeizhongX deleted the rename-tests branch September 21, 2021 23:58
@delan
Copy link
Member

delan commented Sep 23, 2021

Sorry about the mess, these tests landed in both #30692 (upstream) and #30813 (CL:2850068), which I didn’t expect to cause a merge conflict (given that the files on both sides were identical).

@WeizhongX
Copy link
Contributor Author

Thanks for removing the duplicates!

Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
We now have tests with the same file name in chromium and wpt upstream,
which cause a merge conflict when exporting and importing the changes.
Rename the file names at upstream to resolve such conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants