Fixing serialization of grid-auto-flow #30953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 24, 2021
This CL fixes a serialization of grid-auto-flow issue where the word 'row' was being included even though it isn't necessary. The tests grid-auto-flow-computed.html and grid-auto-flow-valid.html are fixed, while the expectations of wpt and fast tests are updated or modified to add new passes. Bug: 1156390 Change-Id: If91100c3eff7b6cd4caf349114afb0fec71e9e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179598 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Cr-Commit-Position: refs/heads/main@{#925295}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3179598
branch
from
0d089c9
to
d104902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL fixes a serialization of grid-auto-flow issue where the word
'row' was being included even though it isn't necessary. The tests
grid-auto-flow-computed.html and grid-auto-flow-valid.html are fixed,
while the expectations of wpt and fast tests are updated or modified to
add new passes.
Bug: 1156390
Change-Id: If91100c3eff7b6cd4caf349114afb0fec71e9e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179598
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#925295}