[css-fonts] Add test for @font-palette-values with an empty font family #30957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
force-pushed
the
font-palette-empty-font-family
branch
from
7772e21
to
d09f2df
Compare
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Sep 25, 2021
https://bugs.webkit.org/show_bug.cgi?id=230598 <rdar://problem/83383955> Reviewed by Tim Horton. It already works. These tests are being upstreamed in web-platform-tests/wpt#30957. * web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-empty-font-family.html: Added. * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html: Canonical link: https://commits.webkit.org/242133@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nt1m
approved these changes
Sep 25, 2021
There was a problem hiding this comment.
Reviewed in WebKit: https://bugs.webkit.org/show_bug.cgi?id=230598
|
Please make sure to fix the lint error before merging though (it seems you already faced the same error elsewhere)! |
|
This patch is stale now; I've updated the font in #31044. |
litherum
force-pushed
the
font-palette-empty-font-family
branch
2 times, most recently
from
71013ad
to
3af50f8
Compare
litherum
force-pushed
the
font-palette-empty-font-family
branch
from
3af50f8
to
3000db1
Compare
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Oct 9, 2021
https://bugs.webkit.org/show_bug.cgi?id=230598 <rdar://problem/83383955> Reviewed by Tim Horton. It already works. These tests are being upstreamed in web-platform-tests/wpt#30957. * web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html: Added. * web-platform-tests/css/css-fonts/font-palette-empty-font-family.html: Added. * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@283075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…ly (web-platform-tests#30957) The relevant WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=230598.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=230598.