Prerender: Upstream a basic test for SpeculationRules triggered prerendering to WPT #30971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 26, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3168517
branch
5 times, most recently
from
8dc0374
to
1a7d071
Compare
…ndering to WPT
This CL upstreams a basic prerender test that confirms
`document.prerendering` and `document.onprerenderingchange` event on
pages prerendered by SpeculationRules to the WPT repository.
> Directory structure
This introduces a new directory speculation-rules/ and a sub directory
speculation-rules/prerender/. Tests for other pre* features triggered by
SpeculationRules will be placed in subdirectories of speculation-rules/.
> Feature detection
The test checks if SpeculationRules is available using
`HTMLScriptElement.supports('speculationrules')`. This doesn't exactly
check if SpeculationRules triggered prerendering is available, but
currently this is the only way to (roughly) detect the feature and still
useful for avoiding timeout on other user agents.
> For VIRTUAL_OWNERS
This CL just moves the existing test to the new directory and updates
the VirtualTestSuites configuration for the directory, so this doesn't
increase the number of tests to run.
Change-Id: I3fbd729de42f560b9157ff1a3b4ba6e4e973a0d6
Bug: 1253158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168517
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926625}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3168517
branch
from
1a7d071
to
851b775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL upstreams a basic prerender test that confirms
document.prerenderinganddocument.onprerenderingchangeevent onpages prerendered by SpeculationRules to the WPT repository.
This introduces a new directory speculation-rules/ and a sub directory
speculation-rules/prerender/. Tests for other pre* features triggered by
SpeculationRules will be placed in subdirectories of speculation-rules/.
The test checks if SpeculationRules is available using
HTMLScriptElement.supports('speculationrules'). This doesn't exactlycheck if SpeculationRules triggered prerendering is available, but
currently this is the only way to (roughly) detect the feature and still
useful for avoiding timeout on other user agents.
This CL just moves the existing test to the new directory and updates
the VirtualTestSuites configuration for the directory, so this doesn't
increase the number of tests to run.
Change-Id: I3fbd729de42f560b9157ff1a3b4ba6e4e973a0d6
Bug: 1253158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168517
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926625}