Add credentials to same-origin Report uploads #30983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 27, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3169200
branch
2 times, most recently
from
7d38bf7
to
8a13b6b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3169200
branch
6 times, most recently
from
d136ebe
to
b6a5704
Compare
When the reporting endpoint is same-origin with the page generating reports, the reporting API specifies that credentials should be included with the report delivery. This change enables that behaviour for V1 reporting endpoints only -- any endpoints configured with the Report-To header are unaffected. This CL corrects the way that we distinguish V0 from V1 endpoints at delivery time, which also corrects the metrics collection for delivered reports, and adds a test for a case which was previously missed. Bug: 1163645 Change-Id: I8fcd934b3026b57374e7e7df31c9af9a8d93962d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169200 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/main@{#929239}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3169200
branch
from
b6a5704
to
7d4e905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the reporting endpoint is same-origin with the page generating
reports, the reporting API specifies that credentials should be included
with the report delivery.
This change enables that behaviour for V1 reporting endpoints only --
any endpoints configured with the Report-To header are unaffected. This
CL corrects the way that we distinguish V0 from V1 endpoints at delivery
time, which also corrects the metrics collection for delivered reports,
and adds a test for a case which was previously missed.
Bug: 1163645
Change-Id: I8fcd934b3026b57374e7e7df31c9af9a8d93962d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169200
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929239}