Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[block-in-inline] Add tests for text-indent #31067

Merged
merged 1 commit into from Oct 1, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 1, 2021

The text-indent property handles the "first formatted line"
differently. This patch adds a test when the text-indent
property is applied to block-in-inline.

r920106 crrev.com/c/3152716 added tests for ::first-line.
This patch tests the same logic but using the text-indent
property.

Bug: 716930
Change-Id: I60874b9ae4b91b6352c97c36d434bc40f2259219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198017
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927414}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The `text-indent` property handles the "first formatted line"
differently. This patch adds a test when the `text-indent`
property is applied to block-in-inline.

r920106 crrev.com/c/3152716 added tests for `::first-line`.
This patch tests the same logic but using the `text-indent`
property.

Bug: 716930
Change-Id: I60874b9ae4b91b6352c97c36d434bc40f2259219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198017
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927414}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants