Prerender: Upstream test for presentationRequest.start() #31257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 15, 2021
This CL upstreams a test for presentationRequest.start() in prerendered pages to the WPT repository. The API is listed as "implicitly restricted APIs" in the draft spec: https://jeremyroman.github.io/alternate-loading-modes/prerendering.html#implicitly-restricted This CL removes the following comment: This cannot be upstreamed as a WPT test because the spec (probably) will require that no error is thrown until activation. This is because presentationRequest.start() is expected to return a rejected promise when the window doesn't have transient activation, and the current test correctly handles it. If the document's active window does not have transient activation, return a Promise rejected with an InvalidAccessError exception and abort these steps. https://w3c.github.io/presentation-api/#dom-presentationrequest-start Related issues in the spec side: - WICG/nav-speculation#42 - WICG/nav-speculation#36 Bug: 1253158 Change-Id: I6973c4c6683135b9bc27e78115d797e8d5840fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223703 Reviewed-by: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#931847}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3223703
branch
from
f21b786
to
e53e44f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL upstreams a test for presentationRequest.start() in prerendered
pages to the WPT repository. The API is listed as "implicitly restricted
APIs" in the draft spec:
https://jeremyroman.github.io/alternate-loading-modes/prerendering.html#implicitly-restricted
This CL removes the following comment:
This cannot be upstreamed as a WPT test because the spec (probably)
will require that no error is thrown until activation.
This is because presentationRequest.start() is expected to return a
rejected promise when the window doesn't have transient activation, and
the current test correctly handles it.
If the document's active window does not have transient activation,
return a Promise rejected with an InvalidAccessError exception and
abort these steps.
https://w3c.github.io/presentation-api/#dom-presentationrequest-start
Related issues in the spec side:
Bug: 1253158
Change-Id: I6973c4c6683135b9bc27e78115d797e8d5840fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223703
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931847}