Integer interpolation should be rounded towards positive infinity. #31282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 17, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3225842
branch
8 times, most recently
from
dc38fc4
to
a922beb
Compare
Currently, interpolation of <integer> is rounding away from 0. The interpolation's result should be rounded according to the spec, https://drafts.csswg.org/css-values-4/#combine-integers, which is "the result is converted to an <integer> by rounding to the nearest integer, with values halfway between adjacent integers rounded towards positive infinity." Bug: 1257732 Change-Id: I0dc9db806b88e66bf326b848c4e4ac90ef868ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225842 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joonghun Park <pjh0718@gmail.com> Cr-Commit-Position: refs/heads/main@{#933277}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3225842
branch
from
a922beb
to
0d3279a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, interpolation of <integer> is rounding away from 0.
The interpolation's result should be rounded according to the spec,
https://drafts.csswg.org/css-values-4/#combine-integers, which is
"the result is converted to an <integer> by rounding
to the nearest integer, with values halfway between
adjacent integers rounded towards positive infinity."
Bug: 1257732
Change-Id: I0dc9db806b88e66bf326b848c4e4ac90ef868ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225842
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Cr-Commit-Position: refs/heads/main@{#933277}