Need to propagate tallest unbreakable before forced breaks. #31313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 19, 2021
Even if there's a forced break inside the child added to the fragment builder, we need to propagate the tallest unbreakable block-size, to get column balancing right. This fixes an existing test, but I felt that we needed a test that more clearly illustrates this fix, so added that. The existing test still fails in legacy layout, but for a different reason (layout is correct, but outline painting order is wrong). Took the opportunity to rename PropagateBreak() to PropagateBreakInfo(), since this method doesn't only care about actual breaks. Also, no need to call this one if no block fragmentation is involved. Bug: 829028 Change-Id: Ie951817095267567b9fae578fd519b4ba76dc24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231178 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#933116}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3231178
branch
from
5f96d23
to
18e08e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if there's a forced break inside the child added to the fragment
builder, we need to propagate the tallest unbreakable block-size, to get
column balancing right.
This fixes an existing test, but I felt that we needed a test that more
clearly illustrates this fix, so added that. The existing test still
fails in legacy layout, but for a different reason (layout is correct,
but outline painting order is wrong).
Took the opportunity to rename PropagateBreak() to PropagateBreakInfo(),
since this method doesn't only care about actual breaks. Also, no need
to call this one if no block fragmentation is involved.
Bug: 829028
Change-Id: Ie951817095267567b9fae578fd519b4ba76dc24c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231178
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#933116}