<script type=webbundle>: Resolve a relative URL on the bundle's URL #31395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 27, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3244822
branch
2 times, most recently
from
5abdeae
to
8fa669c
Compare
The explainer PR is: WICG/webpackage#700 One of the gaps between the Subresource Loading with WebBundles and Bundle Preloading proposals is "how to resolve a relative URL of resources". The former is using document's base URL, and the latter is using the bundle's URL. We have to align. At the era of <link>-based API, using a document's base URL might make sense because `resources` are specified in the link element's attribute. Now we use <script>-based APIs, and `resources` is specified in JSON, so we no longer have any strong reason to use a document's base URL. See the spec discussion for details: WICG/webpackage#699 (comment) Bug: 1263807 Change-Id: Ic71f095589daa42db2d4649e2cf77212616b2f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244822 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/main@{#935333}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3244822
branch
from
8fa669c
to
9304433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explainer PR is: WICG/webpackage#700
One of the gaps between the Subresource Loading with WebBundles and
Bundle Preloading proposals is "how to resolve a relative URL of
resources". The former is using document's base URL, and the latter is
using the bundle's URL. We have to align.
At the era of <link>-based API, using a document's base URL might make
sense because
resourcesare specified in the link element'sattribute.
Now we use <script>-based APIs, and
resourcesis specified in JSON, sowe no longer have any strong reason to use a document's base URL.
See the spec discussion for details:
WICG/webpackage#699 (comment)
Bug: 1263807
Change-Id: Ic71f095589daa42db2d4649e2cf77212616b2f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244822
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935333}