[layout] Fix baseline synthesis. #31405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 27, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3243263
branch
from
0ec412b
to
c971df8
Compare
Previously the APIs: - NGBoxFragment::BaselineOrSynthesize - NGBoxFragment::FirstBaselineOrSynthesize Always synthesized baselines from the block-end edge. Typically in a vertical writing-mode we should be synthesizing from the block-middle, except when we have "text-orientation: sideways". This changes the synthesis APIs to accept a FontBaseline parameter similar to BaselineMetrics to pick the right type of baseline. Change-Id: I2e153442af659c412b72ce70cc520731d46e83be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243263 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/main@{#935691}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3243263
branch
from
c971df8
to
5b62879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the APIs:
Always synthesized baselines from the block-end edge. Typically in a
vertical writing-mode we should be synthesizing from the block-middle,
except when we have "text-orientation: sideways".
This changes the synthesis APIs to accept a FontBaseline parameter
similar to BaselineMetrics to pick the right type of baseline.
Change-Id: I2e153442af659c412b72ce70cc520731d46e83be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3243263
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935691}