Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@layer] Implement layer serialization in @import rules #31428

Merged
merged 1 commit into from Nov 9, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 28, 2021

This patch also fixes a bug in ConsumeAtRulePrelude that the result
prelude may contain leading white spaces. The new test requires the fix
to pass.

Bug: 1095765
Change-Id: Ie565309d38aa208aa0e60b5c862ec1e62a5764b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252521
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937046}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3252521 branch 2 times, most recently from be21965 to 5f5ee16 Compare November 1, 2021 19:15
This patch also fixes a bug in ConsumeAtRulePrelude that the result
prelude may contain leading white spaces. The new test requires the fix
to pass.

Bug: 1095765
Change-Id: Ie565309d38aa208aa0e60b5c862ec1e62a5764b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252521
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937046}
@past
Copy link
Member

past commented Nov 2, 2021

Changes in this PR contain lint errors, listed below. These errors must either be fixed or added to the list of ignored errors; see the documentation.

css/css-cascade/parsing/layer-import.html: The filename layer-import in the css-cascade-5 testsuite is shared by: css/css-cascade/layer-import.html, css/css-cascade/parsing/layer-import.html (CSS-COLLIDING-TEST-NAME)
css/css-cascade/layer-import.html: The filename layer-import in the css-cascade-5 testsuite is shared by: css/css-cascade/layer-import.html, css/css-cascade/parsing/layer-import.html (CSS-COLLIDING-TEST-NAME)

@xiaochengh , @andruud, could you please take a look?

@past
Copy link
Member

past commented Nov 4, 2021

@tabatkins do you know if anything will break spectacularly if I admin-merge this despite the lint error?

@past
Copy link
Member

past commented Nov 9, 2021

Filed crbug.com/1268508 after offline discussion with Tab.

@past past merged commit 00be84d into master Nov 9, 2021
@past past deleted the chromium-export-cl-3252521 branch November 9, 2021 18:43
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
…-tests#31428)

This patch also fixes a bug in ConsumeAtRulePrelude that the result
prelude may contain leading white spaces. The new test requires the fix
to pass.

Bug: 1095765
Change-Id: Ie565309d38aa208aa0e60b5c862ec1e62a5764b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252521
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937046}

Co-authored-by: Xiaocheng Hu <xiaochengh@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants