New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tests for use of currentColor in @font-palette-values #31517
New tests for use of currentColor in @font-palette-values #31517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I agree that use of currentColor in @font-palette-values
is underspecified, but the approach assumed in this test seems reasonable
Uh-oh, I think this is opposite from our implementation 🤔 |
In w3c/csswg-drafts#7010 @litherum explains that From an implementation perspective, I find it difficult to resolve Safari currently does not pass this test, and in my WIP implementation in Chrome, I find this hard to support. |
OK so with that clarification, these tests should be deleted. |
Fine by me to delete these as they don't match the current wording. Agree it is considerably more complex using currentColor in I still think it's important it's both supported and consistent with the way it works elsewhere in terms of inheritance, but that's better discussed in the issue than here. |
This reverts commit e14ed86. As discussed in #31517 and w3c/csswg-drafts#7010
This reverts commit e14ed86. As discussed in web-platform-tests#31517 and w3c/csswg-drafts#7010
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
This reverts commit e14ed86. As discussed in web-platform-tests#31517 and w3c/csswg-drafts#7010
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
… in @font-palette-values", a=testonly Automatic update from web-platform-tests Revert "New tets for use of currentColor in @font-palette-values" This reverts commit e14ed8613f431e528b83f074ce37cf6e22dd95b6. As discussed in web-platform-tests/wpt#31517 and w3c/csswg-drafts#7010 -- wpt-commits: 13b16f2df09ae8b579fbf9ebeca5f6153f494d55 wpt-pr: 32812
New tests to verify use of currentColor in @font-palette-values
override-colors
property.font-palette-36.html makes the assumption that currentColor is inherited in the same way here as everywhere else, but this isn't explicit in the spec.
ping @litherum