Fix flakiness of wpt/web-animations/.../onfinish.html #31562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 9, 2021
assert_equals was being used for time comparisons, which allows for no numerical precision tolerance. Instead, we should be using assert_times_equal, which has a built in tolerance of 1 microsecond. Bug: 1267535 Change-Id: I76be9723645f8e4457b35baa4fe516d6013c6eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270992 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#940005}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3270992
branch
from
19b93c8
to
0a4945b
Compare
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…ests#31562) assert_equals was being used for time comparisons, which allows for no numerical precision tolerance. Instead, we should be using assert_times_equal, which has a built in tolerance of 1 microsecond. Bug: 1267535 Change-Id: I76be9723645f8e4457b35baa4fe516d6013c6eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270992 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#940005} Co-authored-by: Kevin Ellis <kevers@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_equals was being used for time comparisons, which allows for no
numerical precision tolerance. Instead, we should be using
assert_times_equal, which has a built in tolerance of 1 microsecond.
Bug: 1267535
Change-Id: I76be9723645f8e4457b35baa4fe516d6013c6eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270992
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#940005}