[Gecko Bug 1741491] Make sure we only record old style value once. #31665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way CommitStyles called into servo caused it to call the closure multiple times, and we were not dealing with that properly. Handle the "was called" state internally. Differential Revision: https://phabricator.services.mozilla.com/D131411 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1741491 gecko-commit: 00f24d1721eabfa3458ff50b4653ede395d64b70 gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way CommitStyles called into servo caused it to call the closure
multiple times, and we were not dealing with that properly.
Handle the "was called" state internally.
Differential Revision: https://phabricator.services.mozilla.com/D131411
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1741491
gecko-commit: 00f24d1721eabfa3458ff50b4653ede395d64b70
gecko-reviewers: smaug