Invalidate paint when CompositingContainer changes #31734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 24, 2021
PaintLayer::CompositingContainer may change when stacking changes. We mark the previous compositing container for repaint in |LayoutBoxModelObject::StyleWillChange| but also need to mark the new compositing container chain for repaint. Bug: 1271871 Change-Id: Ief05ea5c26ae27ebe2918db293ad8e17a5851a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3300510 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#945205}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3300510
branch
from
a5eb499
to
d2e6412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaintLayer::CompositingContainer may change when stacking changes. We
mark the previous compositing container for repaint in
|LayoutBoxModelObject::StyleWillChange| but also need to mark the new
compositing container chain for repaint.
Bug: 1271871
Change-Id: Ief05ea5c26ae27ebe2918db293ad8e17a5851a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3300510
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945205}