Fix text painting for ::target-text & ::highlight #31750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 25, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3302311
branch
from
c947de4
to
d6e1f91
Compare
::target-text & ::highlight pseudo-elements were not painting the text if the originating element color was transparent. This patch fixes this removing two checks in NGHighlightPainter::Paint(). BUG=1273943 TEST=web_tests/external/wpt/css/css-highlight-api/painting/custom-highlight-painting-017.html TEST=web_tests/external/wpt/css/css-pseudo/target-text-007.html Change-Id: Ie8198e8cf37d6ef89cdee341e84b6bc36ad6ec84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3302311 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/main@{#945638}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3302311
branch
from
d6e1f91
to
a1fc2b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::target-text & ::highlight pseudo-elements were not painting
the text if the originating element color was transparent.
This patch fixes this removing two checks
in NGHighlightPainter::Paint().
BUG=1273943
TEST=web_tests/external/wpt/css/css-highlight-api/painting/custom-highlight-painting-017.html
TEST=web_tests/external/wpt/css/css-pseudo/target-text-007.html
Change-Id: Ie8198e8cf37d6ef89cdee341e84b6bc36ad6ec84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3302311
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/main@{#945638}