[GridFragmentation] Basic support of break-before/break-after on item. #31825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 2, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3287251
branch
from
56e745e
to
037b495
Compare
This implements basic support for break-before/break-after. At the moment it only support the top level break-before/break-after value (not the nested values, until we set up the non-fragmented constraint space correctly). The break-before/break-after values are collected at the grid row level when we calculate the grid (stored in a vector). Currently this also doesn't (yet) search for the row with the highest appeal. Bug: 614667 Change-Id: I0299fa5d7b04106641903607c84fe45470f8a27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287251 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#947733}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3287251
branch
from
037b495
to
d778dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic support for break-before/break-after. At the
moment it only support the top level break-before/break-after value (not
the nested values, until we set up the non-fragmented constraint space
correctly).
The break-before/break-after values are collected at the grid row level
when we calculate the grid (stored in a vector).
Currently this also doesn't (yet) search for the row with the highest
appeal.
Bug: 614667
Change-Id: I0299fa5d7b04106641903607c84fe45470f8a27c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287251
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#947733}