[SelectMenu] Reflect option.selected for selectmenu.value #31854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 2, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3287417
branch
from
ac8d32e
to
4e8e073
Compare
This CL adds support so that updating option.selected will also update selectmenu.value. When the selected value is true, the option is marked as selectmenu's selectedOption. For now, when the selected value is changed to false, the first option is going to be selected (support for reset to default selection is going to be added in a follow up CL). Bug: 1121840 Change-Id: I7f4b9de685cefeb2f549a3e39b1c69f555490d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287417 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#947707}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3287417
branch
from
4e8e073
to
01d7b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support so that updating option.selected will also update
selectmenu.value.
When the selected value is true, the option is marked as selectmenu's
selectedOption. For now, when the selected value is changed to false,
the first option is going to be selected (support for reset to default
selection is going to be added in a follow up CL).
Bug: 1121840
Change-Id: I7f4b9de685cefeb2f549a3e39b1c69f555490d90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287417
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#947707}