URLPattern: Escape some suffixes trailing :foo groups.
#31965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL fixes another problem case from: whatwg/urlpattern#145 In this case we need to detect when a group suffix could be mistaken for trailing custom name characters. When this happens we should escape the first character of the suffix. For example: `{:foo\\bar}` instead of `{:foobar}`. Bug: 1263673 Change-Id: I2aa2d043ef4c71433fdc0be113fcafddf5ad3532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318605 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/main@{#949707}
wpt-pr-bot
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL fixes another problem case from:
whatwg/urlpattern#145
In this case we need to detect when a group suffix could be mistaken
for trailing custom name characters. When this happens we should escape
the first character of the suffix. For example:
{:foo\\bar}insteadof
{:foobar}.Bug: 1263673
Change-Id: I2aa2d043ef4c71433fdc0be113fcafddf5ad3532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318605
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/main@{#949707}