Update render surface status for effect nodes without cc::Layers #32206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 28, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3359379
branch
from
caab397
to
df550c5
Compare
An effect node may need to create a render surface without an associated cc::Layer. Previously the render surface for will-change:opacity and opacity animation was missing in the case because blink_effects collected in PaintArtifactCompositor contained effect nodes associated with cc::Layers only. Move after-update render surface update code from PaintArtifactCompositor into PropertyTreeManager to handle render surfaces for will-change:opacity and opacity animations without layers. Bug: 1123630 Change-Id: I4513657b593b86e18d20c4da690371d3d3cb0910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3359379 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#954389}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3359379
branch
from
df550c5
to
0e71c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effect node may need to create a render surface without an
associated cc::Layer. Previously the render surface for
will-change:opacity and opacity animation was missing in the case
because blink_effects collected in PaintArtifactCompositor contained
effect nodes associated with cc::Layers only.
Move after-update render surface update code from
PaintArtifactCompositor into PropertyTreeManager to handle render
surfaces for will-change:opacity and opacity animations without
layers.
Bug: 1123630
Change-Id: I4513657b593b86e18d20c4da690371d3d3cb0910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3359379
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#954389}