Fieldset: Fix scrollable block size with max-height and LEGEND #32268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 6, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3367584
branch
from
060d2f5
to
73c686c
Compare
We need to take into account of LEGEND block size on computing maximum content block size. Also, max_content_block_size should have a lower limit for smaller max-height. For example, NGFieldsetLayoutAlgorithmTest.ZeroMaxHeight needs the lower limit. Bug: 1282408 Change-Id: I6766465e9dd817ff668b9997c79aa874faa3db3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3367584 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#956373}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3367584
branch
from
73c686c
to
7553ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to take into account of LEGEND block size on computing maximum
content block size.
Also, max_content_block_size should have a lower limit for smaller
max-height. For example, NGFieldsetLayoutAlgorithmTest.ZeroMaxHeight
needs the lower limit.
Bug: 1282408
Change-Id: I6766465e9dd817ff668b9997c79aa874faa3db3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3367584
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#956373}