[Gecko Bug 1749299] Make HTMLEditor::HandleInsertLinefeed() stop handling it if insertion point cannot have text nodes
#32401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on point cannot have text nodes Ideally, it should not be called when the editor cannot insert new text node. However, the callers are complicated. Therefore, let's check in it for avoiding making the callers more complicated. Fortunately, this is not realistic path for normal web apps. Therefore, the compatibility of the behavior is not matter. That's the reason why this patch does not have a test comparing the result. Differential Revision: https://phabricator.services.mozilla.com/D135826 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1749299 gecko-commit: 9ef0614a59629916c1e182eb8eda055b0b0e8b32 gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, it should not be called when the editor cannot insert new text node.
However, the callers are complicated. Therefore, let's check in it for avoiding
making the callers more complicated. Fortunately, this is not realistic path
for normal web apps. Therefore, the compatibility of the behavior is not
matter. That's the reason why this patch does not have a test comparing the
result.
Differential Revision: https://phabricator.services.mozilla.com/D135826
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1749299
gecko-commit: 9ef0614a59629916c1e182eb8eda055b0b0e8b32
gecko-reviewers: m_kato