Support small/large/dynamic/logical viewport units #32635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 1, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3344791
branch
3 times, most recently
from
9675584
to
be5b1f0
Compare
This CL adds support for new units:
* svw, svh (etc): Resolves against the viewport as it would be with
browser controls fully expanded.
* lvw, lvh (etc): Resolves against the viewport as it would be with
browser controls fully minimized.
* dvw, dvh (etc): Resolves against the viewport as it presently
appears given the current state of browser controls.
* vi, vb: Resolves against vw/vh depending on the writing-mode
of the target element.
Note that dv* units are deliberately not responsive to browser control
animations, and will always resolve to either sv* or lv* (not some
value in between). This is to avoid excessive scroll-driven relayouts
on mobile devices.
This CL uses the existing system/bits for invalidation of viewport
units. Targeted invalidation of dynamic units will come in a
subsequent CL.
Bug: 1093055
Change-Id: I3ba55a86de53514f2020a2d5bdda579f06dd9d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344791
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967475}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3344791
branch
from
be5b1f0
to
48be7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for new units:
browser controls fully expanded.
browser controls fully minimized.
appears given the current state of browser controls.
of the target element.
Note that dv* units are deliberately not responsive to browser control
animations, and will always resolve to either sv* or lv* (not some
value in between). This is to avoid excessive scroll-driven relayouts
on mobile devices.
This CL uses the existing system/bits for invalidation of viewport
units. Targeted invalidation of dynamic units will come in a
subsequent CL.
Bug: 1093055
Change-Id: I3ba55a86de53514f2020a2d5bdda579f06dd9d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344791
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967475}