[Gecko Bug 1750634] Add WPT Test for Stream Object globals #32649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 1, 2022
This test is based on the general structure of js/src/tests/non262/ReadableStream/readable-stream-globals.js, however the expectations have been commented and updated to match what we believe is the correct WebIDL behaviour. Not all the features of that test case have been ported over, as there's some stuff around the handling of Symbol.species that we can test elsewhere, and it attempts to test BYOB streams, which we have yet to implement. Note: I tried to initially write this as an xpcshell test case using Cu.sandbox; but I found that I wasn't geting global behaviour that matched my expectations from testing on the web. Differential Revision: https://phabricator.services.mozilla.com/D137492 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1750634 gecko-commit: 7b75650e5e0bcc300a409f54f664efc08ed0c7ba gecko-reviewers: smaug, saschanaz
moz-wptsync-bot
force-pushed
the
gecko/1750634
branch
from
d48abbd
to
60cda28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is based on the general structure of
js/src/tests/non262/ReadableStream/readable-stream-globals.js, however the
expectations have been commented and updated to match what we believe is
the correct WebIDL behaviour.
Not all the features of that test case have been ported over, as there's
some stuff around the handling of Symbol.species that we can test elsewhere,
and it attempts to test BYOB streams, which we have yet to implement.
Note: I tried to initially write this as an xpcshell test case using
Cu.sandbox; but I found that I wasn't geting global behaviour that matched
my expectations from testing on the web.
Differential Revision: https://phabricator.services.mozilla.com/D137492
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1750634
gecko-commit: 00d4eefcf59bda521a129e82b4fdca832cb3a6b1
gecko-reviewers: smaug, saschanaz