Allow fuzzy matching for plus-lighter tests #32834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I was a little confused at having to provide a range for a max |
tabatkins
approved these changes
Feb 14, 2022
|
Yup, afaik that's the correct way to say "literally all of the pixels might be off" |
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests use a JS function to perform the compositing, but it seems like some browsers use a lower precision meaning some results are off-by-one. The lower precision isn't an issue, so I've allowed colors to be off-by-one.
@tabatkins happy with this? I just used a really big number for the number of pixels affected. It doesn't seem like there's a way to say that any pixel can be off by 1.