App history: preserve id and entry object for same-document reloads #32846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 15, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3425162
branch
4 times, most recently
from
cd37bf7
to
fe13b66
Compare
This was largely already done. We just needed to avoid assuming that non-back-forward, non-push navigations were replace navigations. Now we only replace the AppHistoryEntry object same-document replaces, leaving it alone for same-document reloads. Fixed: 1243749 Change-Id: I6c6195de649ba92c717222a4c059e1243e427b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425162 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#978843}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3425162
branch
from
fe13b66
to
0704390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was largely already done. We just needed to avoid assuming that non-back-forward, non-push navigations were replace navigations. Now we only replace the AppHistoryEntry object same-document replaces, leaving it alone for same-document reloads.
Fixed: 1243749
Change-Id: I6c6195de649ba92c717222a4c059e1243e427b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425162
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978843}