[SPC] Add relying party ID input to SPC request #32884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 17, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3456482
branch
2 times, most recently
from
8a64975
to
b9820cd
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3456482
branch
2 times, most recently
from
3506a2c
to
c04aa75
Compare
Implementation for the proposal[1] to add the credential's relying party as input to a SecurePaymentConfirmationRequests. This validates the request's RP ID against the stored SPC credential data as part of the SPC request creation; in the future we also want to forward this to webauthn to look up the credential by the relying party ID as part of the authentication. [1] w3c/secure-payment-confirmation#164 Bug: 1298505 Change-Id: If8a305dfb608050107966b2bb6f365a3d2aeb18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456482 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#981645}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3456482
branch
from
c04aa75
to
6237da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for the proposal[1] to add the credential's relying party
as input to a SecurePaymentConfirmationRequests.
This validates the request's RP ID against the stored SPC credential
data as part of the SPC request creation; in the future we also want to
forward this to webauthn to look up the credential by the relying party
ID as part of the authentication.
[1] w3c/secure-payment-confirmation#164
Bug: 1298505
Change-Id: If8a305dfb608050107966b2bb6f365a3d2aeb18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3456482
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981645}