Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Add column balancing test with break-before:avoid #32959

Merged
merged 1 commit into from Feb 24, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 24, 2022

Add test that would fail without the call to PropagateSpaceShortage()
in AttemptSoftBreak().

Bug: 829028
Change-Id: Ida35140bc73535f05ae343700ee6c911c42271f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3485447
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#974679}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3485447 branch 2 times, most recently from e665ef1 to 2e8c545 Compare February 24, 2022 15:55
Add test that would fail without the call to PropagateSpaceShortage()
in AttemptSoftBreak().

Bug: 829028
Change-Id: Ida35140bc73535f05ae343700ee6c911c42271f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3485447
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#974679}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants