[block-in-inline] Fix hit-testing when inline box is not culled #32997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 27, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3489020
branch
4 times, most recently
from
d73d674
to
b78dc2d
Compare
This patch fixes hit-testing block-in-inline when the inline box is not culled. This issue was originally reported at crbug.com/1300205, but also affects crrev.com/c/3486321 for crbug.com/1301136. Two logic changes are included: 1. Hit-testing should ignore opaque inline boxes. The |IsOpaque| flag was added in r908729 crrev.com/c/3066831 because inline boxes that wraps block-in-inline are not visible to layout and paint except some paint effects. 2. r925189 crrev.com/c/3181220 hit-tests block-backgrounds while in the foreground phase. This resulted ignoring floats, because floats are between foreground and block background. https://drafts.csswg.org/css2/#painting-order This patch reverts the change. Note that the change 1 does not apply to list-based hit- testing. This is needed for: external/wpt/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html when the inline with block children is not culled (crrev.com/c/3486321). Bug: 1300205, 1301136 Change-Id: Ie94df6092fe7d50599ab4f985233cf0dfa968efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489020 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#975579}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3489020
branch
from
b78dc2d
to
9678c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes hit-testing block-in-inline when the inline
box is not culled. This issue was originally reported at
crbug.com/1300205, but also affects crrev.com/c/3486321 for
crbug.com/1301136.
Two logic changes are included:
|IsOpaque| flag was added in r908729 crrev.com/c/3066831
because inline boxes that wraps block-in-inline are not
visible to layout and paint except some paint effects.
while in the foreground phase. This resulted ignoring
floats, because floats are between foreground and block
background. https://drafts.csswg.org/css2/#painting-order
This patch reverts the change.
Note that the change 1 does not apply to list-based hit-
testing. This is needed for:
external/wpt/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html
when the inline with block children is not culled (crrev.com/c/3486321).
Bug: 1300205, 1301136
Change-Id: Ie94df6092fe7d50599ab4f985233cf0dfa968efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489020
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975579}