Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of onload = t.step_timeout in WPT tests #33034

Merged
merged 1 commit into from Mar 3, 2022
Merged

Fix usage of onload = t.step_timeout in WPT tests #33034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app-history/currentchange-event/currentchange-app-history-back-forward-same-doc.html
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
promise_test(async t => {
// Wait for after the load event so that the navigation doesn't get converted
// into a replace navigation.
await new Promise(resolve => window.onload = t.step_timeout(resolve, 0));
await new Promise(resolve => window.onload = () => t.step_timeout(resolve, 0));
await appHistory.navigate("#foo").committed;
assert_equals(appHistory.entries().length, 2);

Expand Down
2 changes: 1 addition & 1 deletion app-history/currentchange-event/currentchange-app-history-navigate-replace-same-doc.html
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
promise_test(async t => {
// Wait for after the load event so that the navigation doesn't get converted
// into a replace navigation.
await new Promise(resolve => window.onload = t.step_timeout(resolve, 0));
await new Promise(resolve => window.onload = () => t.step_timeout(resolve, 0));

let oncurrentchange_called = false;
let original_entry = appHistory.current;
Expand Down
2 changes: 1 addition & 1 deletion app-history/currentchange-event/currentchange-app-history-navigate-same-doc.html
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
promise_test(async t => {
// Wait for after the load event so that the navigation doesn't get converted
// into a replace navigation.
await new Promise(resolve => window.onload = t.step_timeout(resolve, 0));
await new Promise(resolve => window.onload = () => t.step_timeout(resolve, 0));

let oncurrentchange_called = false;
appHistory.oncurrentchange = t.step_func(e => {
Expand Down
2 changes: 1 addition & 1 deletion app-history/currentchange-event/currentchange-history-back-same-doc.html
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
promise_test(async t => {
// Wait for after the load event so that the navigation doesn't get converted
// into a replace navigation.
await new Promise(resolve => window.onload = t.step_timeout(resolve, 0));
await new Promise(resolve => window.onload = () => t.step_timeout(resolve, 0));
await appHistory.navigate("#foo");
assert_equals(appHistory.entries().length, 2);

Expand Down
2 changes: 1 addition & 1 deletion app-history/navigate-event/navigate-history-back-after-fragment.html
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
<script src="/resources/testharnessreport.js"></script>
<script>
async_test(t => {
window.onload = t.step_timeout(() => {
window.onload = () => t.step_timeout(() => {
let start_length = history.length;
let target_key = appHistory.current.key;
let target_id = appHistory.current.id;
Expand Down
2 changes: 1 addition & 1 deletion app-history/navigate-event/navigate-history-back-after-pushState.html
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
<script src="/resources/testharnessreport.js"></script>
<script>
async_test(t => {
window.onload = t.step_timeout(() => {
window.onload = () => t.step_timeout(() => {
let start_length = history.length;
let target_key = appHistory.current.key;
let target_id = appHistory.current.id;
Expand Down
2 changes: 1 addition & 1 deletion html/semantics/forms/the-selectmenu-element/selectmenu-form-state-restore.tentative.html
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@

<script>
async_test(t => {
window.onload = t.step_timeout(() => {
window.onload = () => t.step_timeout(() => {
let state = document.getElementById('emptyOnFirstVisit');
let selectMenu = document.getElementById("selectmenu0");

Expand Down