Reland "[FedCM] Split get() into get()+login()" #33059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 4, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3498694
branch
from
9bb3b6d
to
030df07
Compare
This reverts commit 2b540bc952136e552b98559fe0ddb4e149b39941. Reason for revert: Fixed compile error Original change's description: > Revert "[FedCM] Split get() into get()+login()" > > This reverts commit a6fba024e6fdead47455a413362261326e0ab7a6. > > Reason for revert: Might have caused compile failure > https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/62048? > > Original change's description: > > [FedCM] Split get() into get()+login() > > > > This is a consequence of > > fedidcg/FedCM@e49c2bb > > > > Bug: 1300009 > > Change-Id: I36839e0e5748d1014e624d64f40d393fec4d2b91 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499423 > > Reviewed-by: Yi Gu <yigu@chromium.org> > > Reviewed-by: Sam Goto <goto@chromium.org> > > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#977460} > > Bug: 1300009 > Change-Id: I6a1e3250f82f4111eac6c841127d044d197af97f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499935 > Auto-Submit: Keishi Hattori <keishi@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Owners-Override: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#977469} Bug: 1300009 Change-Id: Ibac6509a4a0657b8d2b8c6ff0c32dd1e25fcaf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498694 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#977759}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3498694
branch
from
030df07
to
3f348cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2b540bc952136e552b98559fe0ddb4e149b39941.
Reason for revert: Fixed compile error
Original change's description:
Bug: 1300009
Change-Id: Ibac6509a4a0657b8d2b8c6ff0c32dd1e25fcaf9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498694
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977759}