Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navigation reporting coop tests more resilient #33105

Merged
merged 1 commit into from Mar 9, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 8, 2022

Make navigation reporting COOP tests more resilients by increasing
the timeout when monitoring for reports. This should reduce the number
of flakes.

Fixed: 1218065
Change-Id: I2713e404e3f9cd589dc72fd15abfa5b5a67d997e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500410
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978681}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Make navigation reporting COOP tests more resilients by increasing
the timeout when monitoring for reports. This should reduce the number
of flakes.

Fixed: 1218065
Change-Id: I2713e404e3f9cd589dc72fd15abfa5b5a67d997e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500410
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978681}
@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-openee_coop-ro_cross-origin.https.html   OK: 6/7, TIMEOUT: 1/7  
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-openee_coop-ro_cross-origin.https.html access-from-coop-page-to-openee, cross-origin FAIL: 6/7, MISSING: 1/7 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-openee_coop-ro_cross-origin.https.html access-from-coop-page-to-openee, cross-origin + redirect FAIL: 6/7, MISSING: 1/7 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-other_coop-ro_cross-origin.https.html   CRASH: 1/7, OK: 6/7  
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-other_coop-ro_cross-origin.https.html access-to-coop-page-from-other (COOP-RO) FAIL: 6/7, MISSING: 1/7 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/property-close.https.html   CRASH: 1/7, OK: 6/7  
/html/cross-origin-opener-policy/reporting/access-reporting/property-close.https.html same-origin > w => w.close() FAIL: 6/7, MISSING: 1/7 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-close.https.html cross-origin > w => w.close() FAIL: 6/7, MISSING: 1/7 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-self.https.html   CRASH: 1/7, OK: 6/7  
/html/cross-origin-opener-policy/reporting/access-reporting/property-self.https.html same-origin > w => w.self FAIL: 6/7, MISSING: 1/7 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-self.https.html cross-origin > w => w.self FAIL: 6/7, MISSING: 1/7 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-window.https.html   CRASH: 1/7, OK: 6/7  
/html/cross-origin-opener-policy/reporting/access-reporting/property-window.https.html same-origin > w => w.window FAIL: 6/7, MISSING: 1/7 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-window.https.html cross-origin > w => w.window FAIL: 6/7, MISSING: 1/7 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX
Copy link
Contributor

Submitted https://bugs.chromium.org/p/chromium/issues/detail?id=1304275

@past, can you pls admin merge this? thanks!

@past past merged commit c91659d into master Mar 9, 2022
@past past deleted the chromium-export-cl-3500410 branch March 9, 2022 23:55
@past
Copy link
Member

past commented Mar 9, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants