New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make navigation reporting coop tests more resilient #33105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Make navigation reporting COOP tests more resilients by increasing the timeout when monitoring for reports. This should reduce the number of flakes. Fixed: 1218065 Change-Id: I2713e404e3f9cd589dc72fd15abfa5b5a67d997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500410 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#978681}
e2bd8be
to
f19bcd2
Compare
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
Submitted https://bugs.chromium.org/p/chromium/issues/detail?id=1304275 @past, can you pls admin merge this? thanks! |
Merged, thanks! |
Make navigation reporting COOP tests more resilients by increasing
the timeout when monitoring for reports. This should reduce the number
of flakes.
Fixed: 1218065
Change-Id: I2713e404e3f9cd589dc72fd15abfa5b5a67d997e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500410
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978681}