[FlexNG] Expansion and %-block-size descendant #33133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 9, 2022
Similar to CL:3508504, update MinBlockSizeShouldEncompassIntrinsicSize to consider %-block-size descendants and update related tests to catch the bug. Note: This will prevent a future issue where we may loop indefinitely while expanding the related row as a result of expanding in this case. Bug: 660611 Change-Id: I8658de8043475d862498234bb6c10e7b58a383d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3514592 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#979389}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3514592
branch
from
0c47c5e
to
4ed5ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to CL:3508504, update MinBlockSizeShouldEncompassIntrinsicSize
to consider %-block-size descendants and update related tests to catch
the bug.
Note: This will prevent a future issue where we may loop indefinitely
while expanding the related row as a result of expanding in this case.
Bug: 660611
Change-Id: I8658de8043475d862498234bb6c10e7b58a383d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3514592
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#979389}