Move hint to the provider dictionary #33140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 9, 2022
This makes more sense because the account IDs will be different for each provider. This also matches the spec: https://fedidcg.github.io/FedCM/#dom-federatedidentityprovider-hint Bug: 1300009 Change-Id: I690867414a6266dc61b00c12103d9e408a22ec24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3514293 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/main@{#979875}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3514293
branch
from
53a418f
to
3f9fe6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes more sense because the account IDs will be different for
each provider.
This also matches the spec:
https://fedidcg.github.io/FedCM/#dom-federatedidentityprovider-hint
Bug: 1300009
Change-Id: I690867414a6266dc61b00c12103d9e408a22ec24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3514293
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979875}