[renderblocking] Implement render-blocking on preload and modulepreload links #33195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 15, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3527422
branch
2 times, most recently
from
29e380a
to
9772cb0
Compare
…ad links This patch blocks rendering on render-blocking preload and modulepreload links, and also unifies that with the existing short render-blocking on font preloads. The previous attempt (crrev.com/c/3514642) uses Resource and ResourceFinishObserver to listen to the loading progress of render-blocking preloads. However, this approach does not extend to modulepreload links as PreloadHelper::ModulePreloadIfNeeded() does not expose a ScriptResource to callers. This patch uses a different approach. It uses LinkLoaderClient to listen to the loading progress, which works on both preload and modulepreload links. This is also closer to the spec compared to the previous one. Bug: 1271296 Change-Id: I4923e81362180aad3de8c3352241c228515e7ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3527422 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#982964}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3527422
branch
from
9772cb0
to
6d607dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch blocks rendering on render-blocking preload and modulepreload
links, and also unifies that with the existing short render-blocking on
font preloads.
The previous attempt (crrev.com/c/3514642) uses Resource and
ResourceFinishObserver to listen to the loading progress of render-blocking
preloads. However, this approach does not extend to modulepreload links
as PreloadHelper::ModulePreloadIfNeeded() does not expose a
ScriptResource to callers.
This patch uses a different approach. It uses LinkLoaderClient to listen
to the loading progress, which works on both preload and modulepreload
links. This is also closer to the spec compared to the previous one.
Bug: 1271296
Change-Id: I4923e81362180aad3de8c3352241c228515e7ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3527422
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982964}