Add a WPT for 304 and CORP interaction. #33341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 24, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3547677
branch
3 times, most recently
from
b02a158
to
4399d79
Compare
Currently, 304 responses do not set the CORP header, which seems to be the correct behavior according to https://datatracker.ietf.org/doc/html/rfc7232#section-4.1 On the other hand this causes issue because we incorrectly consider that the cached request did not set CORP, and ends up being blocked by COEP, which is definitely not an appropriate behavior. This introduces a WPT verifying the behavior, and does some minor cosmetic changes to the test it's based upon. Bug: 1241264 Change-Id: Id44439cdde63b292377587b74bdd9b6fa10f1e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547677 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/main@{#984934}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3547677
branch
from
4399d79
to
731c329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, 304 responses do not set the CORP header, which seems to be
the correct behavior according to
https://datatracker.ietf.org/doc/html/rfc7232#section-4.1
On the other hand this causes issue because we incorrectly consider
that the cached request did not set CORP, and ends up being blocked by
COEP, which is definitely not an appropriate behavior.
This introduces a WPT verifying the behavior, and does some minor
cosmetic changes to the test it's based upon.
Bug: 1241264
Change-Id: Id44439cdde63b292377587b74bdd9b6fa10f1e65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547677
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#984934}