Ensure fallback setup when manual slots are inserted into shadow DOM #33440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 31, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3562222
branch
2 times, most recently
from
ce9dbd1
to
7edeb4c
Compare
When a new slot is added to a shadow DOM with manual slot assignment, while the slot is guaranteed to not have any assigned node, it may still have fallback content. This patch ensures that the fallback content is correctly set up, so that it can be correctly rendered, and can be correctly cleared when the slot gets an assignment. Test cases: - imperative-slot-initial-fallback.html: Tests that the fallback content of an imperative slot is correctly rendered if it has no assignment - imperative-slot-fallback-clear.html: Tests that after rendering the fallback content and then getting an assignment, an imperative slot can correctly clear the fallback content Fixed: 1292292 Change-Id: I74403ab7c6003a9a0203cfdce1c2896f9529499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3562222 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#988106}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3562222
branch
from
7edeb4c
to
6431912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new slot is added to a shadow DOM with manual slot assignment,
while the slot is guaranteed to not have any assigned node, it may still
have fallback content. This patch ensures that the fallback content is
correctly set up, so that it can be correctly rendered, and can be
correctly cleared when the slot gets an assignment.
Test cases:
of an imperative slot is correctly rendered if it has no assignment
fallback content and then getting an assignment, an imperative slot
can correctly clear the fallback content
Fixed: 1292292
Change-Id: I74403ab7c6003a9a0203cfdce1c2896f9529499e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3562222
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988106}