Always rebuild CascadeLayerMap if active style sheets changed #33525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 6, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3572544
branch
from
41c970e
to
94e6c08
Compare
The existing implementation: - Resets a tree scope's style (include cascade layers) if the change type is ActiveSheetsChanged - Rebuilds a tree scope's cascade layers only if the changed sheets involve cascade layers This results in a bug that we if modify a sheet that does not have cascade layers, then the previous CascadeLayerMap is cleared but not rebuilt, and as a result, all previously previously layered rules break into the default layer. This patch fixes it by rebuilding the CascadeLayerMap in that case. Layer-related invalidations remain the same as before. Fixed: 1313357 Change-Id: I702a6421416aea2634537b6d9650399b68e25f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3572544 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#989813}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3572544
branch
from
94e6c08
to
19813e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation:
type is ActiveSheetsChanged
involve cascade layers
This results in a bug that we if modify a sheet that does not have
cascade layers, then the previous CascadeLayerMap is cleared but not
rebuilt, and as a result, all previously previously layered rules
break into the default layer.
This patch fixes it by rebuilding the CascadeLayerMap in that case.
Layer-related invalidations remain the same as before.
Fixed: 1313357
Change-Id: I702a6421416aea2634537b6d9650399b68e25f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3572544
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#989813}