Speculative fix for show-picker-cross-origin-iframe #33653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 15, 2022
On wpt.fyi, this test is sometimes failing with an error that says "target frame detached": https://wpt.fyi/results/html/semantics/forms/the-input-element/show-picker-cross-origin-iframe.html?run_id=5741165811859456 I can't reproduce this locally, but I figured that maybe since this test reuses the same iframe, maybe it would be better to use one iframe per test. Bug: 1316643 Change-Id: If99e6a8c2d983a5db7d9d463d47f97289f923fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3588678 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#993377}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3588678
branch
from
afe2d59
to
9786fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wpt.fyi, this test is sometimes failing with an error that says
"target frame detached":
https://wpt.fyi/results/html/semantics/forms/the-input-element/show-picker-cross-origin-iframe.html?run_id=5741165811859456
I can't reproduce this locally, but I figured that maybe since this test
reuses the same iframe, maybe it would be better to use one iframe per
test.
Bug: 1316643
Change-Id: If99e6a8c2d983a5db7d9d463d47f97289f923fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3588678
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#993377}