Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect custom --adb-binary for chrome_android-derived products #33654

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Respect custom --adb-binary for chrome_android-derived products #33654

merged 2 commits into from
Apr 15, 2022

Commits on Apr 15, 2022

  1. Respect custom --adb-binary for chrome_android-derived products 

    Previously, `chrome_android`-derived products depended on finding a
generic `adb` on the `PATH`. The Chromium infrastructure was changed to
use `--adb-binary` instead of `PATH` pollution, but the option did not
work as documented because wptrunner did not pass the option all the way
through.
    @jonathan-j-lee
    jonathan-j-lee committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    feb65f4 View commit details
    Browse the repository at this point in the history

  2. Check that adb_binary is truthy, not merely that it exists

    @jonathan-j-lee
    jonathan-j-lee committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    d31f5e5 View commit details
    Browse the repository at this point in the history