Revert "Make ComputeIsFixedContainer return false for SVG elements other than" #33725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 20, 2022
…her than" This reverts commit c2b3bfc165b94cc8cab039b3c1b3b9ae21039c45. Reason for revert: Didn't fixed bug https://bugs.chromium.org/p/chromium/issues/detail?id=1316974 Original change's description: > Make ComputeIsFixedContainer return false for SVG elements other than > foreignObject > > Make ComputeIsFixedContainer return false for SVG elements other than > foreignObject as this check is irrelevant for SVG elements and caused > inconsistency problems. > > Also add crash tests. > > Fixed: 1308025 > Change-Id: I3fe211d2e13839ced2464c3204f5e035d145f4b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561852 > Reviewed-by: David Baron <dbaron@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Yotam Hacohen <yotha@chromium.org> > Cr-Commit-Position: refs/heads/main@{#988943} Change-Id: I6905c8c50bb312006178778a430b41c635d76bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597703 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/main@{#994421}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3597703
branch
from
6de5d56
to
eecea32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c2b3bfc165b94cc8cab039b3c1b3b9ae21039c45.
Reason for revert: Didn't fixed bug https://bugs.chromium.org/p/chromium/issues/detail?id=1316974
Original change's description:
Change-Id: I6905c8c50bb312006178778a430b41c635d76bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597703
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994421}