[renderblocking] Allow manual unblocking of rendering #33774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 25, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3601726
branch
2 times, most recently
from
e322a38
to
bbadfb2
Compare
This patch makes sure that we can manually unblock rendering on an element by removing its `blocking=render` attribute or by simply removing the element from DOM. The only new implementation change is that when the `blocking` attribute of a <style> or <script> element changes, if it changes to non-render-blocking, then we unblock rendering. All other DOM changes are already handled by existing code. This patch also adds new WPT tests for the behavior. Note: The spec does not require such behavior -- it only requires when the UA must not render, but there's no requirement of when the UA must render. So the tests are marked as "optional". Bug: 1271296 Change-Id: Iead14b73014370ea72e6eeb6714b75cc56de974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601726 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#995853}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3601726
branch
from
bbadfb2
to
91dbb12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes sure that we can manually unblock rendering on an
element by removing its
blocking=renderattribute or by simplyremoving the element from DOM.
The only new implementation change is that when the
blockingattribute of a <style> or <script> element changes, if it changes to
non-render-blocking, then we unblock rendering. All other DOM changes
are already handled by existing code.
This patch also adds new WPT tests for the behavior.
Note: The spec does not require such behavior -- it only requires when
the UA must not render, but there's no requirement of when the UA must
render. So the tests are marked as "optional".
Bug: 1271296
Change-Id: Iead14b73014370ea72e6eeb6714b75cc56de974f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601726
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995853}