Fix reflection of missing in referrerPolicy attribute #33775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 25, 2022
With this change, a missing referrerPolicy (correctly) reflects to IDL as an empty string. As suggested on [1], this was likely just a typo in the original implementation. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1154266#c4 Fixed: 1154266 Change-Id: I4909430b53dce500662ea1a5207a81ac55ff7d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600596 Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#995761}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3600596
branch
from
62da1e3
to
78e87d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, a missing referrerPolicy (correctly) reflects to
IDL as an empty string. As suggested on [1], this was likely just
a typo in the original implementation.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1154266#c4
Fixed: 1154266
Change-Id: I4909430b53dce500662ea1a5207a81ac55ff7d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600596
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995761}