Prerender: Defer ServiceWorkerRegistration#unregister from prerendered pages #33780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 25, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3606768
branch
from
7fe3acf
to
52d2110
Compare
…d pages The spec requires ServiceWorkerRegistration#unregister to be deferred until page activation. This CL implements the behavior. https://wicg.github.io/nav-speculation/prerendering.html#patch-service-workers Bug: 1305120 Change-Id: Ibf5d888f0636d2ad11c08f16b9b9739824536cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606768 Reviewed-by: Lingqi Chi <lingqi@chromium.org> Reviewed-by: Asami Doi <asamidoi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#995987}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3606768
branch
from
52d2110
to
57be653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec requires ServiceWorkerRegistration#unregister to be deferred
until page activation. This CL implements the behavior.
https://wicg.github.io/nav-speculation/prerendering.html#patch-service-workers
Bug: 1305120
Change-Id: Ibf5d888f0636d2ad11c08f16b9b9739824536cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606768
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Asami Doi <asamidoi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995987}