Add tests for LCP entries caused by CSS generated text #33790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 26, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3608050
branch
2 times, most recently
from
c2e896f
to
11eae46
Compare
The tests will: - Check if a LCP entry is being generated for CSS generated text - Check if a LCP entry is being generated for CSS generated text from the attr() function - Check if a LCP entry is being generated for CSS generated text on inline elements Bug: 994414 Change-Id: Iec2207944744e1264382bd0e7b7ed9059ad8ee19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608050 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#997647}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3608050
branch
from
11eae46
to
7886ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests will:
the attr() function
inline elements
Bug: 994414
Change-Id: Iec2207944744e1264382bd0e7b7ed9059ad8ee19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608050
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#997647}